#11273: Riemann Enhancements: Docs, Exterior, Multiple Spiderweb, Error Testing
---------------------------+------------------------------------------------
Reporter: evanandel | Owner: burcin
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: calculus | Keywords: riemann map
Work_issues: | Upstream: N/A
Reviewer: | Author: Ethan Van Andel
Merged: | Dependencies: #8867, #10792, #10821, #11028
---------------------------+------------------------------------------------
Changes (by burcin):
* dependencies: 8867, 10792, 10821, 11028 => #8867, #10792, #10821,
#11028
Comment:
Replying to [comment:1 evanandel]:
> As a result, this ticket should replace #10945 (some of the other issues
there have already been addressed, this just hits the documentation) and
#10957. Is there a good way to go about doing that?
We should close those tickets as duplicates of this one.
The patch looks good to me. There are a few minor formatting issues:
* lines should be <= 80 characters. The patch contains some lines with
very aggressive wrapping, such as
{{{
q_vector = 1 / (
self.pre_q_vector - pt1)
}}}
and some with almost none.
* There should be an empty line in the documentation after `::` to start
a code block.
* I would appreciate it if there were more comments in the code to
explain what it's doing, but this is not a requirement.
* attachment:trac-11273-riemann-upgrade-part2.patch cuts down the
precision required in the doctests to 5 digits in some places. Is this
code really so unstable? Would it help to use other functions for numeric
approximation, other than those defined in python's `math` module?
I am leaving this as `needs_review` since I don't consider this a full
review. Somebody more familiar with this code should comment on the
changes and check if this ticket does indeed replace #10945 and #10957.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11273#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
