#11273: Riemann Enhancements: Docs, Exterior, Multiple Spiderweb, Error Testing
--------------------------------------------------+-------------------------
Reporter: evanandel | Owner: burcin
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.7.1
Component: calculus | Keywords: riemann
map
Work_issues: | Upstream: N/A
Reviewer: Burcin Erocal, Karl-Dieter Crisman | Author: Ethan Van
Andel
Merged: | Dependencies: #8867,
#10792, #10821, #11028
--------------------------------------------------+-------------------------
Changes (by kcrisman):
* status: needs_review => needs_work
* reviewer: => Burcin Erocal, Karl-Dieter Crisman
Comment:
A few other comments.
First, ones to make sure it replaces #10945.
* Presumably the redefinition of `I` is supposed to demonstrate it works
with lots of different complex types. I suggest the following.
{{{
Can work for different types of complex numbers::
sage: m = Riemann_Map([lambda t: e^(I*t) - 0.5*e^(-I*t)],
[lambda t: I*e^(I*t) + 0.5*I*e^(-I*t)], 0) # long time (4 sec)
sage: m.riemann_map(0.25 + sqrt(-0.5)) # long time
(0.137514137885...+0.876696023004...j)
+ sage: I = CDF.gen() # long time
sage: m.riemann_map(1.3*I) # long time
(-1.561029396...+0.989694535737...j)
- sage: I = CDF.gen() # long time
sage: m.riemann_map(0.4) # long time
}}}
* From #8867: "It now properly avoids failing with lambda functions,
although it doesn't work optimally for them. I'll add some notes on that
in #10945."
Then a few other comments.
* Incorrect indentation in the last couple functions (in addition to the
empty lines Burcin mentioned).
* Some math things could be put in single backticks, like 2*pi.
* Commit messages should have the Trac ticket number in them, like ''Trac
11273, major additions"
* Commit message should have a short first line, then the rest of the
information.
----
Hope to later do a better review of the content, which I think I will be
able to do. This does need some work due to all these formatting etc.
issues, though.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11273#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
