#11273: Riemann Enhancements: Docs, Exterior, Multiple Spiderweb, Error Testing
--------------------------------------------------+-------------------------
   Reporter:  evanandel                           |          Owner:  burcin     
                  
       Type:  enhancement                         |         Status:  
needs_review                 
   Priority:  major                               |      Milestone:  sage-4.7.1 
                  
  Component:  calculus                            |       Keywords:  riemann 
map                  
Work_issues:                                      |       Upstream:  N/A        
                  
   Reviewer:  Burcin Erocal, Karl-Dieter Crisman  |         Author:  Ethan Van 
Andel              
     Merged:                                      |   Dependencies:  #8867, 
#10792, #10821, #11028
--------------------------------------------------+-------------------------
Changes (by evanandel):

  * status:  needs_work => needs_review


Comment:

 Alright I've added a patch that should fix all the formatting fixes
 mentioned.

 Regarding code comments, given the complexity of the algorithm, it seemed
 more suitable to me to link to the appropriate mathematical papers than to
 attempt to fully document the algorithm in the code.

 Regarding test precision, no the code is not that unstable. It seems
 stable to about 10 decimal places or so (although not for nearly 0
 values). However, being an numerical algorithm, it is only accurate to
 roughly 5 decimal places for the number of collocation points in the
 tests. Therefore it seemed appropriate to try and match the tests to that
 precision so that if future tweaks change the results--maybe even making
 them more precise--that won't cause the tests to fail unnecessarily.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11273#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to