#11028: More Modular ComplexPlot
-----------------------------------+----------------------------------------
   Reporter:  evanandel            |          Owner:  jason, was              
       Type:  enhancement          |         Status:  needs_info              
   Priority:  minor                |      Milestone:  sage-4.7.1              
  Component:  graphics             |       Keywords:  complex plot riemann map
Work_issues:                       |       Upstream:  N/A                     
   Reviewer:  Karl-Dieter Crisman  |         Author:  Ethan Van Andel         
     Merged:                       |   Dependencies:                          
-----------------------------------+----------------------------------------
Changes (by kcrisman):

  * status:  needs_review => needs_info


Comment:

 A few thoughts:
  * In the first example you move up your definition of `f` and `fprime`.
 But then you define them again.  The definitions of `f` and `fprime` in
 the second example can probably be omitted, right?
  * Good catch on the `hf`s that should have been `fprime`s.
  * I think that the change to !ComplexPlot is a good one, except it is now
 no longer a complex plot!  Now it really is a 'color plot', by
 initialization!  So it allows users how to decide how to represent their
 data, as you say - but complex or otherwise.  Maybe you should make the
 !ColorPlot the main method, and then let a !ComplexPlot be the
 initialization of this with zvalues instead of the color array.
  * I understand the two different `mag_to_lightness` functions.  I still
 don't understand the difference between the two `complex_to_rgb`
 functions.  What is it?

 So 'needs info', at least.  These are all meta-issues in some way.  The
 details seem fine!  (Haven't actually applied or run tests, as I'm
 currently doing so with a different big job - but I have few doubts on
 that score.)


 ----
 By the way, give my best to Mike Bolt.  He told me he worked with a
 student in [http://pjm.math.berkeley.edu/involve/2010/3-4/p05.xhtml this
 paper in Involve], and I knew you were at Calvin, but somehow I didn't put
 it all together!

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11028#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to