#10347: Implementation of is_(skew_)symmetrizable for matrices
-----------------------------+----------------------------------------------
Reporter: stumpc5 | Owner: tbd
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7.1
Component: combinatorics | Keywords: symmetrizable matrix
Work_issues: | Upstream: N/A
Reviewer: Hugh Thomas | Author: Christian Stump
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by stumpc5):
Replying to [comment:15 hthomas]:
Hi Hugh,
> I was reading a bit more about what referees are supposed to do, and one
thing is that they should be enforcing the convention that every function,
even those beginning with an underscore, should have examples showing it
in action. (This is according to William Stein's blog post on
refereeing.) This isn't true of _travel_column. Is this something that
should be fixed, or should I not be taking what William Stein writes
literally in this case?
I don't really know -- I added an example, but as this function is not
used anywhere but inside _check_symm..., the example doesn't give any
inside to the reader. On the other hand, if someone brakes this function
for whatever reason, then the doctest catches this. That's a huge plus!
Best, Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10347#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
