#11430: is_pseudoprime_small_power has bugs with get_data=True
--------------------------------+-------------------------------------------
Reporter: itolkov | Owner: itolkov
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.1
Component: basic arithmetic | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Mariah Lenox | Author: Igor Tolkov
Merged: | Dependencies:
--------------------------------+-------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => Mariah Lenox
* author: => Igor Tolkov
Old description:
> {{{
> sage: is_pseudoprime_small_power(31^2, get_data=True)
> [(31, 2)]
> sage: is_pseudoprime_small_power(31, get_data=True)
> True
> }}}
>
> Also, code can be written much better.
New description:
{{{
sage: is_pseudoprime_small_power(31^2, get_data=True)
[(31, 2)]
sage: is_pseudoprime_small_power(31, get_data=True)
True
}}}
Also, code can be written much better.
'''Apply''': [attachment:trac_11430_pseudoprime.patch]
--
Comment:
I applied the patch to sage-4.7.1.alpha2, did 'sage -b', and verified that
the patch fixed the reported problem. I then did 'make testlong'. All
tests passed. Positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11430#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
