#11339: Illegal use of __deallocate__ in cython (pyx) code
-----------------------------------------------+----------------------------
Reporter: gagern | Owner: drkirkby
Type: defect | Status: needs_info
Priority: major | Milestone: sage-4.7.1
Component: algebra | Keywords: sd31
Work_issues: | Upstream: N/A
Reviewer: François Bissey, Steven Trogdon | Author: Volker Braun,
Martin von Gagern
Merged: | Dependencies:
-----------------------------------------------+----------------------------
Comment(by malb):
Replying to [comment:27 vbraun]:
Hi, first: thanks for cleaning up the mess that no-doubt I made.
> I had similar problems, but I thought I fixed them and it did pass tests
on my
> machine. In my experience, they always go away if we leak the ring
(which is
> essentially what we did before) instead of cleaning up after we are done
with it.
Ah, this might also explain #5949 then.
> I have a suspicion that, although almost all take a ring as argument,
some Singular
> functions require `currRing` to be set.
The API is as follows: `pXXX` does assume the `currRing` to be set,
whereas `p_XXX` does not. However, sometimes there are bugs, i.e. you call
`p_XXX` and it crashes unless `currRing` is set.
> This is why I added the inlined `_check_ring()` function to each
`MPolynomial_libsingular` method to make
> sure that we have the right `currRing`.
TBH, I don't like this blanket approach, did you run into specific
problems? If so, I'd add a check to those functions instead of hiding bugs
by forcing the ring.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11339#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
