#11422: modular subgroups
--------------------------------+-------------------------------------------
   Reporter:  vdelecroix        |          Owner:  vdelecroix                   
               
       Type:  enhancement       |         Status:  needs_work                   
               
   Priority:  major             |      Milestone:  sage-4.7.1                   
               
  Component:  modular forms     |       Keywords:  group, arithmetic, linear 
group, sl, modular
Work_issues:  doctest failures  |       Upstream:  N/A                          
               
   Reviewer:                    |         Author:  Vincent Delecroix            
               
     Merged:                    |   Dependencies:                               
               
--------------------------------+-------------------------------------------

Comment(by vdelecroix):

 Hello,

 Thanks for starting to look at this.

 Replying to [comment:4 davidloeffler]:
 > This looks great -- I always meant to do some more work on this but
 never got around to it, and you are clearly much better equipped to do so
 than I. Sadly there are masses of doctest failures (48 of them on a clean
 4.7.1.alpha3 build with just your patch applied).  Almost all of them look
 like this:
 > {{{
 > TypeError: cycle_tuples() takes no keyword arguments
 > }}}

 There was a dependancy problem with #10335 which is now in the
 description.

 > Also, some gripes:
 >
 > - The English is a bit ropey in some of the docstrings (e.g. "vue",
 "canonic").

 I'm not a native speaker and it's not easy to find where the errors are.
 In the new version I will post in few minutes, I have tried to be
 attentive to the language.

 > - Some more explanation of what a few of the functions are doing would
 be nice -- e.g. what is canonical about the canonical labels?

 Could you be more precise ? In the new version, I expanded some of the
 documentations (especially the canonical labels).

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11422#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to