#11422: modular subgroups
-----------------------------+----------------------------------------------
Reporter: vdelecroix | Owner: vdelecroix
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: modular forms | Keywords: group, arithmetic, linear
group, sl, modular
Work_issues: | Upstream: N/A
Reviewer: | Author: Vincent Delecroix
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by vdelecroix):
* status: needs_work => needs_review
* work_issues: corrections to docstrings =>
Comment:
Thanks for the detailed report.
> Algorithm comments:
>
> - For permutation subgroups, almost all calculations are done with a
relabelled version, but this is generated anew every time! I'd suggest:
>
> - having a flag that remembers whether the group is already
canonically labelled,
>
> - when that's not the case, caching the canonically labelled version.
Totally right. I choose to add an attribute _canonical_label_group when
the group with canonical renumbering has been computed.
> - At line 1019 of {{{arithgroup.py}}}, if check is True, won't this
cause the check code to be run *twice*?
I don't think so. The function __call__ is called only once, the
__contains__ method does not call the constructor and the __init__ method
of ArithmeticSubgroupElement does not care about wheter or not the element
is in the subgroup "parent" given as argument.
> Corrections to docstrings:
I made the corrections.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11422#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
