#3416: Weierstrass form for cubics
-------------------------------+--------------------------------------------
Reporter: moretti | Owner: was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: elliptic curves | Keywords: nagell, weierstrass, cubic,
elliptic curves, editor_wstein
Work_issues: | Upstream: N/A
Reviewer: | Author: Niels Duif
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Comment(by mstreng):
You can't remove patches (unless you have special rights on the trac
server). But whenever you upload a patch, you can help reviewers and
release managers by writting (preferably both in comments and in the
ticket description) which patches to apply and in which order. If you
follow a [http://wiki.sagemath.org/buildbot certain syntax] in the
comments, then an additional bonus is that your patches will get
automatically tested by the buildbot.
I almost gave you a negative review because of the following, but it seems
that this is not something introduced by you, but just an error that was
already there:
The documentation of {{{EllipticCurve_from_cubic}}} says that P should be
a tuple, but the function only accepts lists (e.g. {{{[-1,0,1]}}}), not
tuples (e.g. {{{(-1,0,1)}}}). Well, I guess I need to work harder for a
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/3416#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
