#11021: clean up sage-spkg
-----------------------------------------+----------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: packages | Keywords: SPKG.txt SAGE.txt
-info BUILD sage-env sage-sage
Work_issues: | Upstream: N/A
Reviewer: Kelvin Li, Leif Leonhardy | Author: Leif Leonhardy,
Kelvin Li
Merged: | Dependencies:
-----------------------------------------+----------------------------------
Changes (by newvalueoldvalue):
* keywords: SPKG.txt SAGE.txt -info => SPKG.txt SAGE.txt -info BUILD
sage-env sage-sage
* priority: minor => major
* reviewer: Kelvin Li => Kelvin Li, Leif Leonhardy
* author: Leif Leonhardy => Leif Leonhardy, Kelvin Li
Old description:
> One of the patches at #9960 did a lot of clean-up to the file `sage-
> spkg`: quoting environment variables, replacing tabs with spaces, etc.,
> also adding comments and TODOs. Since those changes were not related to
> the issue at #9960, I've split them off and put them here instead. The
> main change of any content is to look at the file `SPKG.txt` rather than
> `SAGE.txt` when the "`-info`" flag is passed so `sage-spkg` (through
> `sage -info ...`). Also, warnings and error messages are now redirected
> to `stderr`.
>
> Apply '''only''' [attachment:trac_11021-sage-spkg-
> cleanup-v2-rebased_to_4.7.1.alpha4.patch] to the '''scripts repo'''.
New description:
One of the patches at #9960 did a lot of clean-up to the file `sage-spkg`:
quoting environment variables, replacing tabs with spaces, etc., also
adding comments and TODOs. Since those changes were not related to the
issue at #9960, I've split them off and put them here instead. The main
change of any content is to look at the file `SPKG.txt` rather than
`SAGE.txt` when the "`-info`" flag is passed so `sage-spkg` (through `sage
-info ...`). Also, warnings and error messages are now redirected to
`stderr`.
Apparently support for `sage -info ...` was removed at some point (or
never existed); the patch to `sage-sage` fixes that.
The patch to `sage-env` fixes a bug caused or enabled by #10469, which
through the patch to `sage-spkg` now becomes more visible and potentially
worse.
Apply
1. [attachment:trac_11021-sage-spkg-
cleanup-v2-rebased_to_4.7.1.alpha4.patch]
1. [attachment:trac_11021-support_and_document_sage_-info_in_sage-
sage.scripts.patch]
1. [attachment:trac_11021-export_BUILD_in_sage-env.scripts.patch]
to the '''scripts repo'''.
--
Comment:
The other two patches I've attached fix issues that came up while testing
the patch to `sage-spkg` with Sage 4.7.1.alpha4.
They're both necessary to make `sage -info ...` as well as `sage-spkg` in
general (with the changes made by the other patch) work.
Cf. http://trac.sagemath.org/sage_trac/ticket/10469#comment:24.
Please review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11021#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
