#11021: clean up sage-spkg
--------------------------------------+-------------------------------------
Reporter: jhpalmieri | Owner: tbd
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-4.7.1
Component: packages | Keywords: SPKG.txt SAGE.txt -info
Work_issues: Rebase to 4.7.1.alpha4 | Upstream: N/A
Reviewer: Kelvin Li | Author: Leif Leonhardy
Merged: | Dependencies:
--------------------------------------+-------------------------------------
Changes (by leif):
* status: needs_review => needs_work
* work_issues: => Rebase to 4.7.1.alpha4
Comment:
Hmmm, for Sage 4.7.1.alpha4, we'll have to rebase the patch:
{{{
applying /home/leif/Sage/patches/trac_11021-sage-spkg-cleanup-v2.patch
patching file sage-spkg
Hunk #3 succeeded at 59 (offset 4 lines).
Hunk #4 succeeded at 93 (offset 4 lines).
Hunk #5 succeeded at 139 (offset 4 lines).
Hunk #6 succeeded at 164 (offset 4 lines).
Hunk #7 succeeded at 183 (offset 4 lines).
Hunk #8 succeeded at 191 (offset 4 lines).
Hunk #9 succeeded at 226 (offset 4 lines).
Hunk #10 succeeded at 250 (offset 4 lines).
Hunk #11 succeeded at 273 (offset 4 lines).
Hunk #12 succeeded at 292 (offset 4 lines).
Hunk #13 FAILED at 304
Hunk #14 succeeded at 402 (offset 4 lines).
Hunk #15 succeeded at 413 (offset 4 lines).
Hunk #16 succeeded at 439 (offset 4 lines).
1 out of 16 hunks FAILED -- saving rejects to file sage-spkg.rej
abort: patch failed to apply
}}}
Sorry for the delay btw, been busy with other things.
Though there are still some things that could be improved (e.g. still two
instances of `build` rather than `$BUILD` IIRC), and I would have put the
`>&2` right after `echo` to be more obvious, I'm ok with your changes.
I.e., I'll rebase the patch as is, test it, and if ''you're'' ok with
''my'' previous changes, we'd have a positive review.
(Other things like supporting `SAGE_CHECK=ignore` and what else we've
mentioned on this ticket can be implemented on follow-ups, we just have to
get this ticket merged first... :) )
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11021#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
