#11589: faster zero matrix creation
------------------------------+---------------------------------------------
Reporter: malb | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Martin Albrecht, Simon King
Merged: | Dependencies:
------------------------------+---------------------------------------------
Comment(by SimonKing):
I added a third patch, that applies the faster way of creating a zero
matrix to `_multiply_strassen`. With the third patch, all tests from
sage/matrix still pass. I have no benchmark that shows a noticeable
difference to the old behaviour. But I think it won't hurt to use an
optimised procedure for the creation of a zero matrix, rather than to
hard-wire the copying of a zero matrix in the current version of
_multiply_strassen.
I think that the third patch is small enough to be discussed here.
However, note that there already is an open ticket on improving matrix
multiplication: #8096. There is no activity for 16 months now! I think it
would be worth while to invest some work there. It seems to me that a part
of the issues of that old ticket are already resolved.
Concerning reviews: I believe that the first patch is fine, and I give it
a positive review. I have already mentioned that the tests pass, and the
improvement of the timings (in particular when the second patch is added)
is clear.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11589#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
