#11592: Improvements to units convert function
-----------------------------+----------------------------------------------
Reporter: eviatarbach | Owner: burcin
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.7.2
Component: symbolics | Keywords: units
Work_issues: | Upstream: N/A
Reviewer: Burcin Erocal | Author: Eviatar Bach
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* keywords: => units
* reviewer: => Burcin Erocal
* type: enhancement => defect
* status: needs_review => needs_work
* author: => Eviatar Bach
Comment:
Thanks for the patch. Looks good to me, though a few minor changes are
necessary before I can switch to positive review.
The patch bot shows failing tests in `sage/symbolic/expression.pyx`. While
fixing those, please update the commit message to contain something
meaningful in the first line. Deleting the first 2 lines of the current
message should suffice.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11592#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
