#11624: List Sidon g-sets
-----------------------------+----------------------------------------------
Reporter: mraum | Owner: sage-combinat
Type: enhancement | Status: new
Priority: minor | Milestone: sage-4.7.2
Component: combinatorics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Martin Raum
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Comment(by nborie):
Hello,
I downloaded the patch, it applied and worked well.
I never played with Sidon sets before and know relatively nothing about
them. I did that as first computation :
{{{
sage: [len(sidon_sets(i)) for i in range(1,21)]
[2, 4, 6, 10, 14, 20, 26, 36, 46, 60, 74, 94, 114, 140, 166, 202, 238,
284, 330, 390]
}}}
And asked the Sloane for what does it look like :
Number of binary partitions: number of partitions of 2n into powers of 2.
So, is there a bug in the algorithm or I am perhaps missing something...
It seems to me that the algorithm miss some Sidon sets. I don't really
know...
For example, Sloane tell that [1,2,4,8,13] is a Sidon set but currently
the algorithm returns:
{{{
sage: max([len(S) for S in sidon_sets(13)])
4
}}}
On the technical point of view, the sage code convention is to indent by
block of 4 spaces. don't use tabulation... It should look like that:
{{{
def bla():
r"""
Some doc
EXAMPLES::
sage: some example
TESTS::
sage: some test
}}}
There is a micro typo line 44 of the patch -> Valuerror
Sorry for my poor English... Put the status "needs review" when you will
feel the job is finish from your side. This will be a nice add.
Cheers,
Nicolas.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11624#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
