#11597: Dimension of the singular set
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: algebraic geometry | Keywords: toric
Work_issues: | Upstream: N/A
Reviewer: Andrey Novoseltsev | Author: Volker Braun
Merged: | Dependencies:
----------------------------------+-----------------------------------------
Changes (by newvalueoldvalue):
* keywords: => toric
* reviewer: => Andrey Novoseltsev
* author: => Volker Braun
Old description:
> This patch adds a method `dimension_singularities()` to toric varieties
> that computes the dimension of the singular set. This is usually one of
> the first questions one has, so I find it rather convenient to have a
> method for it. It also adds an optional `fan.is_smooth(codim=d)` argument
> for expert use, though in practice I think its easy to get confused with
> dimension and codimension so I did '''not''' add a similar optional
> argument to `toric_variety.is_smooth()`.
New description:
This patch adds a method `dimension_singularities()` to toric varieties
that computes the dimension of the singular set. This is usually one of
the first questions one has, so I find it rather convenient to have a
method for it. It also adds an optional `fan.is_smooth(codim=d)` argument
for expert use, though in practice I think its easy to get confused with
dimension and codimension so I did '''not''' add a similar optional
argument to `toric_variety.is_smooth()`.
'''Apply:'''
1. [attachment:trac_11597_fan_smooth_dimension.patch]
1. [attachment:trac_11597_reviewer.patch]
--
Comment:
I've changed the documentation a little and replaced `d` for codimension
with `c` as otherwise I was getting very confused thinking of `d` as
dimension. I also switched the function to automatic caching and made it
reuse codimension smoothness computation. If everything looks OK, please
switch to positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11597#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
