#9739: Handle duplicate file basenames when testing multiple files in parallel
-------------------------------+--------------------------------------------
Reporter: mpatel | Owner: mvngu
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.7.1
Component: doctest | Keywords: doctest scripts
Work_issues: | Upstream: N/A
Reviewer: Robert Bradshaw | Author: Mitesh Patel, John Palmieri
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Comment(by leif):
Replying to [comment:57 jhpalmieri]:
> Replying to [comment:56 leif]:
> > (As discussed, I'd also change the ''default'' for `SAGE_TESTDIR`,
e.g. to `tempfile.gettempdir()`.)
>
> I know that I was suggesting this earlier, but on further reflection, we
shouldn't do this here: for example, there may be users who expect the
doctesting files to be in `.sage/tmp/`, and changing this may therefore
make people unhappy. I think it's a good idea, but it should be on
another ticket. (I'm agreeing with Dave's point that we should try to fix
just the bug here, and then we can work on other improvement separately.)
That was my opinion; Dave earlier requested extensions to allow
''simultaneous'' testing (including `make test`[`long`] etc.) of
''multiple'' (possibly the same) Sage installations in the "same"
directory (`SAGE_TESTDIR`), i.e. without having to manually set
`SAGE_TESTDIR` in different shells.
As further enhancements, we should perhaps print the location at the
beginning, and also at the end if any doctest errors occurred. (I'm right
now not sure if `GLOBAL_ITER` etc. get printed, I only recall we should
also print '''either''' `SAGE_TIMEOUT` '''or''' `SAGE_TIMEOUT_LONG`,
whichever is appropriate, as many people seem to misunderstand the meaning
and perhaps also don't know the defaults, which are btw. ''wall'' time and
not CPU time -- perhaps subject to change later as well... :) .)
(A few `print` statements wouldn't complicate the patch ''here'' though.
And if we print `SAGE_TESTDIR` anyway, we could at the same time change
its default to a sensible value as well.)
[[BR]]
> > P.S.: Why not base the patch on Mitesh's? (Which AFAIR only needed two
changes.)
>
> No good reason.
Hmmm. Mitesh fixed some other things as well, so we should somehow make
sure the changes don't get lost once this ticket is merged / closed. (I
remember having reviewed them last year, before he updated the patch again
though IIRC. I think Robert was also ok with his changes, except for the
creation of directories / the temporary files' names and locations.)
Unfortunately, there are meanwhile ''many'' "concurrent" tickets dealing
with the doctest scripts.
I'd of course also like to see my comments from the [comment:32 inline
patch to `sage-ptest` above] in it... ;-) (Just the comments, which are
FIXMEs / TODOs, not [necessarily] the `flush()`s.)
[[BR]]
I'll apply and take a look at your second patch later.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9739#comment:59>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
