#9739: Handle duplicate file basenames when testing multiple files in parallel
-------------------------------+--------------------------------------------
Reporter: mpatel | Owner: mvngu
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.7.1
Component: doctest | Keywords: doctest scripts
Work_issues: | Upstream: N/A
Reviewer: Robert Bradshaw | Author: Mitesh Patel, John Palmieri
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Comment(by jhpalmieri):
Here is a patch based on Mitesh's; the "delta" patch shows the changes;
these changes include your in-line patch. This does not change
SAGE_TESTDIR to `tempfile.gettempdir()`: we store timing information in
this directory, so it should not be temporary. It might be a good idea to
change `TMP` (as used in `sage-ptest`) to a temporary directory, but I
didn't make this change either, just added a comnent about it.
The changes:
- the filename mangling uses the full path of the file rather than
`tempfile.mkstemp`; this should be good enough, especially since we work
in a directory with name determined by the pid and the hostname.
- there was one situation in which the temporary files stored in
`tmpfiles` needed to be deleted but weren't; this was the case before any
of the patches.
- there are now messages printed about the doctesting directory, and then
deleting it at the end.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9739#comment:63>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
