#11686: Race condition in matplotlib mkdir()
------------------------------+---------------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-4.7.2
Component: packages | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Leif Leonhardy | Author: John Palmieri
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by leif):
* reviewer: => Leif Leonhardy
Comment:
Replying to [comment:23 leif]:
> Replying to [comment:22 leif]:
> > So somehow Sage's `libpng*.pc` appears to be "broken". [[BR]]
> > [...]
{{{
prefix=${SAGE_ROOT}
}}}
> does no longer work unless `SAGE_ROOT` is also defined in the `.pc` file
itself.
It never did that way; I used `$${SAGE_ROOT}`.
> We may have to really wrap `pkg-config` in `$SAGE_ROOT/local/bin` [...]
We don't have to, and shouldn't do so (see e.g. [comment:ticket:10202:26
this comment] at #10202).
[[BR]]
So what's the current status of this ticket?
Is the attached diff (and the spkg) still current, or did you / do you
plan to make further changes to `spkg-install` (w.r.t. to applying the
patches) and the `setupext.py` patch?
I think the `pkg-config` issues (on Linux) have shown to be rather
unrelated to this ticket (and MPL itself), so the patch to `setupext.py`
may not have to only be applied on MacOS X (if `pkg-config` is installed),
though limiting its application shouldn't hurt either.
If you want to leave the code as is, I'll re-review and test it now. The
only thing I noticed is that `SPKG.txt` isn't very explicit regarding the
patch to `setupext.py`, i.e. what it currently exactly does and that it's
indeed only applied on Darwin. I'd consider this a minor issue though.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11686#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
