#11686: Race condition in matplotlib mkdir()
------------------------------+---------------------------------------------
Reporter: jdemeyer | Owner: tbd
Type: defect | Status: needs_info
Priority: minor | Milestone: sage-4.7.2
Component: packages | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Leif Leonhardy | Author: John Palmieri
Merged: | Dependencies:
------------------------------+---------------------------------------------
Comment(by jhpalmieri):
I'm considering modifying SPKG.txt as follows:
{{{
#!diff
diff --git a/SPKG.txt b/SPKG.txt
--- a/SPKG.txt
+++ b/SPKG.txt
@@ -40,7 +40,11 @@ The following patches are in the patches
The patches are applied during the build process.
* setupext.py: link to libpng12 instead of libpng to apparently avoid
- some name clashes on OSX. See Sage trac #4774.
+ some name clashes on OSX. As of version 1.0.1.p0, this patch is
+ only applied on OS X, and it tests for the presence of
+ 'pkg-config': if it is not installed, then it links to libpng12
+ instead of libpng; otherwise it does nothing. See Sage trac #4774
+ and #11686.
* __init__.py, finance.py, texmanager.py: instead of "if
not.os.path.exists(DIR): os.mkdir(DIR)", do "try os.mkdir(DIR)" and
@@ -75,8 +79,20 @@ The patches are applied during the build
=== matplotlib 1.0.1.p0 (John Palmieri, 13 Aug 2011) ===
* Patch __init__.py, finance.py, and texmanager.py to avoid race
conditions when creating directories. See Sage trac #11686
- and #10159. Also replaced the "src" directory with a freshly
- downloaded copy of the vanilla source code.
+ and #10159.
+
+ * Updated the list of prerequisites in this file.
+
+ * Changed spkg-install so that the patches are now applied using
+ 'patch'.
+
+ * The patch to setupext.py is now only applied on OS X. The patch
+ itself tests whether pkg-config is installed: if so, it maintains
+ the status quo, and if not, it passes the argument 'libpng12' when
+ configuring then png package.
+
+ * Replaced the "src" directory with a freshly downloaded copy of
+ the vanilla source code.
=== matplotlib 1.0.1 (Ryan Grout, 10 Jan 2011) ===
* Update to matplotlib 1.0.1. Fixes a handful of annoying bugs in SAGE.
}}}
Re `SAGE_MATPLOTLIB_GUI`: I'm not sure what to check, so I'm hoping we can
do this on a follow-up ticket. ("We" meaning someone else, actually.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11686#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
