#11556: Linear transformations, built from free module morphisms
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Martin Raum | Author: Rob Beezer
Merged: | Dependencies: #11552, #11553
------------------------------+---------------------------------------------
Changes (by mraum):
* reviewer: => Martin Raum
Comment:
Hi Robert,
There are very few changes that I propose for this patch. Sorry, for not
making them myself, but I somehow happened to lack time again.
1. Add newline at the end of free_module_morphism.py.
2. In vector_space_morphism.py l.475f it is not clear what side refers to.
Delete the sentence?
3. l. 639 of the same file contains a typo.
4. l. 689ff do the imports globally. If for conflicts you cannot move the
import statements to the file's head, move at least as many as you can.
5. l. 756ff is indeed no sufficient to check for linearity. Is there a
specific reason why you don't use is_polynomial()? Then check the degree
and you are fine.
6. l. 775 do you want to keep that line or rather merge with l. 732?
7. l. 856 move this import if possible
With these very minor changes made, this ticket deserves a positive
review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11556#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
