#11556: Linear transformations, built from free module morphisms
------------------------------+---------------------------------------------
Reporter: rbeezer | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Martin Raum | Author: Rob Beezer
Merged: | Dependencies: #11552, #11553
------------------------------+---------------------------------------------
Comment(by rbeezer):
Replying to [comment:5 mraum]:
> 2. In vector_space_morphism.py l.475f it is not clear what side refers
to.
> Delete the sentence?
Actual output from {{{_repr_()}}} once made it clearer, but I trimmed the
amount of output later. I will expand the sentence.
> 5. l. 756ff is indeed no sufficient to check for linearity. Is there a
> specific reason why you don't use is_polynomial()? Then check the degree
> and you are fine.
I did not think I could fully protect against all possible symbolic
expressions sneaking through. But I had not thought about
is_polynomial() which sounds like a good idea.
> 6. l. 775 do you want to keep that line or rather merge with l. 732?
Mistaken leftover from various attempts to get unique parents. ;-)
> 7. l. 856 move this import if possible
Generally: I did some reading a few months ago about imports, and got the
impression that there was very little cost to placing within a method a
statement like
{{{
import foo.bar
}}}
and then subsequently calling as
{{{
answer = foo.bar.stuff()
}}}
This is not exactly what is happening at l. 856, but on other tickets, you
have suggested moving imports. What is the best strategy? I thought in
module headers it would count against startuptime? Guess I'm just
confused on what is best.
Thanks for all the help on all these tickets. It is really good to see
them all getting wrapped up.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11556#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
