#11686: Race condition in matplotlib mkdir()
------------------------------------------------------------------------------------------------------------+
Reporter: jdemeyer
| Owner: tbd
Type: defect
| Status: positive_review
Priority: minor
| Milestone: sage-4.7.2
Component: packages
| Keywords: MPL Errno 14 libpng
Work_issues: Either check for pkg-config on other platforms as well, or make
the ticket depend on #11696. | Upstream: N/A
Reviewer: Leif Leonhardy
| Author: John Palmieri
Merged:
| Dependencies:
------------------------------------------------------------------------------------------------------------+
Changes (by leif):
* keywords: => MPL Errno 14 libpng
* status: needs_review => positive_review
Comment:
Replying to [comment:50 jhpalmieri]:
> Replying to [comment:49 leif]:
> > (by checking for pkg-config in the patch itself)
>
> As I noted earlier, someone might install pkg-config without recompiling
Sage or this spkg, so it makes sense to me to test this at run-time, not
just at installation.
Well, the code is only executed when MPL gets installed, and the file
itself doesn't get installed anywhere AFAIK.
[[BR]]
> > the attached diff doesn't move the patch (to `setupext.py` btw., the
commit message is wrong) from `patches/Darwin/` to `patches/`.
>
> It actually does, but it's hard to see in the patch: it's right after
the header for "spkg-install".
I see. Also the spkg is ok, so I'll give it positive review again, also
based on your comment that it works on iras (which I would expect it to
anyway).
[[BR]]
> I'll fix the commit message, and I'll look at #11696 eventually. It's
easy enough for me to test on Darwin.
Perhaps on some ancient Darwin systems as well if you can.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11686#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
