#11028: More Modular ComplexPlot
-----------------------------------+----------------------------------------
Reporter: evanandel | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.7.2
Component: graphics | Keywords: complex plot riemann map
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Ethan Van Andel
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Changes (by kcrisman):
* status: needs_info => needs_review
Comment:
Replying to [comment:11 evanandel]:
> * Those redefinitions could be omitted, but I generally think that it
makes it more readable for each example section to define its functions
unless it's very time or space consuming. If that violates a sage
convention though, it can certainly be changed.
Ok.
> * It may make more sense to put ColorPlot as the main method. If that
is the case, however, then it seems like color plot should be given its
own module (it certainly doesn't belong in complex_plot) and then perhaps
complex_plot() should move elsewhere since it's not apparent that it needs
a whole module for just a couple functions. If that is the case though,
that seems like a refactoring decision that is above my (hypothetical) pay
grade. If it turns out to be complicated, it might be better just to let
this patch go through and deal with that question separately.
Well, that's true.
> * I think the only difference between the two complex_to_rgb functions
is that each one uses a different mag_to_lightness function. I couldn't
figure out a better way to avoid code re-use since it's reasonable to
expect other methods that access ColorPlot to define complex_to_rgb
methods that differ in more than just mag_to_lightness, or for the
existing methods to be modified later without wishing to affect the other.
Ok, I guess my usual plan is to push refactoring to later, too :)
> Those are my thoughts on the issues raised. Does that clear things up?
Yes.
So I'll try to review this, and then finish #11273.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11028#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
