#11707: Remove `readlink -n` and `realpath` from $SAGE_ROOT/sage
------------------------+---------------------------------------------------
   Reporter:  jdemeyer  |          Owner:            
       Type:  defect    |         Status:  new       
   Priority:  major     |      Milestone:  sage-4.7.2
  Component:  scripts   |       Keywords:  SAGE_ROOT 
Work_issues:            |       Upstream:  N/A       
   Reviewer:            |         Author:            
     Merged:            |   Dependencies:            
------------------------+---------------------------------------------------

Comment(by tornaria):

 Replying to [comment:8 leif]:
 > It is not immediately clear why using `pwd -P`, which fully expands
 symbolic links, and therefore would canonicalize `$SAGE_ROOT` as well,
 should break doctesting.

 The issue is described in comment:ticket:5852:12. Summary:

  - there's a symlink {{{/home/wstein/sage-build -> /tmp/wstein}}}
  - sage is untarred and compiled inside {{{/home/wstein/sage-
 build/sage-x.y/}}}
  - doctesting as {{{sage -t /home/wstein/sage-x.y/...}}}

 The last step fails if SAGE_ROOT is fully canonicalized to
 {{{/tmp/wstein/sage-x.y/...}}} because in that case the doctesting code
 didn't realize {{{/home/wstein/sage-x.y/...}}} is library code. IOW, that
 workflow worked for William ''because'' canonicalization was broken!

 I presume the fix is that the comparision done for detecting library code
 be done with using canonical paths, etc.


 > Even if it did somehow, this should be addressed in the corresponding
 scripts, `sage-{test,ptest,doctest}`, which are currently under work
 anyway, and have certainly changed since #5852 was opened (or last
 modified).

 I agree. I haven't followed the development of these scripts, so I
 wouldn't know if the issue was addressed or not. If it is fixed, then
 #5852 can be reapplied and then #6164 can easily be turned into a patch
 that extends canonicalization to other systems where readlink -f is not
 available.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11707#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to