#11657: the vector(...) function is extremely slow
------------------------------+---------------------------------------------
Reporter: was | Owner: jason, was
Type: defect | Status: needs_info
Priority: minor | Milestone: sage-4.7.2
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: Rob Beezer
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by rbeezer):
* status: needs_review => needs_info
Comment:
Replying to [comment:4 was]:
> Now Rob (say) has to review this new patch.
Yes, I've got it. Looks good and ''nearly'' optimal. Nothing much to add
in the way of performance.
Comments:
Line 127 - typo in comments "slowedue"
Line 447 - return statement with zero vector should now be dead code - at
least we want it to be. Commenting-it out and running tests confirms.
The comment preceding needs adjustment.
Line 665 - is the whole discussion about "or" now moot with the super-fast
``is_Ring()`` defined earlier?
Line 670 - error message: can we say "first argument must be a ring"
rather than "arg0 must be a ring"?
Reactions? I can make a follow-up patch for you to review, or vice-versa?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11657#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
