#11734: sage_wraps should only read the sources of wrapped functions when
needed.
--------------------------+-------------------------------------------------
Reporter: SimonKing | Owner: jason
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.7.2
Component: misc | Keywords: sage_wraps sources gentoo
startuptime sd32
Work_issues: | Upstream: N/A
Reviewer: Simon King | Author:
Merged: | Dependencies:
--------------------------+-------------------------------------------------
Changes (by SimonKing):
* reviewer: => Simon King
* author: Simon King =>
Comment:
Concerning documentation: It looks very nice!
Just for testing, I had inserted a function with a complicated argument
list, and put it under the @singular_standard_options decorator:
{{{
@singular_standard_options
def MyTestFunc(bla, blubb, bar={'bla':{1:2}}, foo=None, **kwds):
"""
This is just a test
"""
return
}}}
It is shown in the reference manual exactly as it should.
In addition, the doc tests pass, the startup time seems to slightly
improve (perhaps not significantly), and the memory consumption decreases
a little.
I hope I understood correctly that it will fix the problem on gentoo.
In general, if a bug is fixed, it should be demonstrated by a new doc
test. The example that I gave above ''does'' fail (at least for me)
without the patch. So, I think it should be included. If nobody beats me
to it, I'd provide that example in a referee patch.
Also I don't know the real name of saraedum. So, please insert the name in
the Author field.
Apart from that, it is a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11734#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
