#11750: CRT_list not working for non-coprime moduli
-----------------------------------------------------------------------+----
Reporter: mderickx |
Owner: tbd
Type: defect |
Status: positive_review
Priority: major |
Milestone: sage-4.7.2
Component: basic arithmetic |
Keywords:
Work_issues: |
Upstream: N/A
Reviewer: Luis Felipe Tabera Alonso, Wai Yan Pong, Leif Leonhardy |
Author: Maarten Derickx
Merged: |
Dependencies:
-----------------------------------------------------------------------+----
Changes (by leif):
* status: needs_review => positive_review
* reviewer: Luis Tabera, Wai Yan Pong => Luis Felipe Tabera Alonso, Wai
Yan Pong, Leif Leonhardy
Comment:
Ok, although I would have written something like
''"But '''if some of the moduli have non-trivial common divisors'''
there is not always a solution:"''
(otherwise ''non coprime'' should have a hyphen in it, but that's IMHO a
minor issue).
So '''positive review''' from me. (Feel free to revert this in case you
disagree or want to change the patch again.)
----
P.S.:
I left the ticket as "needs review" since I expected some response from
any of the author(s) or other reviewers (i.e., their opinion). Since it
was still needing review anyway, I didn't set it to "needs info".
If I had been 100% sure about "comprime" being a typo, I would have set it
to "needs work" of course (and changed the ticket's title myself). Adding
an explanatory sentence to the new example was just a suggestion, of IMO
minor importance.
----
P.P.S.: Jeroen requested us to use unique (i.e. full) names in the
"Author(s)" and "Reviewer(s)" fields, so I changed Luis' according to his
wiki list entry.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11750#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
