#11750: CRT_list not working for non-coprime moduli
-----------------------------------------------------------------------+----
Reporter: mderickx |
Owner: tbd
Type: defect |
Status: positive_review
Priority: major |
Milestone: sage-4.7.2
Component: basic arithmetic |
Keywords:
Work_issues: |
Upstream: N/A
Reviewer: Luis Felipe Tabera Alonso, Wai Yan Pong, Leif Leonhardy |
Author: Maarten Derickx
Merged: |
Dependencies:
-----------------------------------------------------------------------+----
Comment(by pong):
Here is my review:
1) The patch is correct.
2) when I ran ./sage --testall --long it complained about cmdline.py
sage -t --long -force_lib "devel/sage/sage/tests/cmdline.py"
there are 4 failures. But I suspect they have nothing to do with this
patch.
3) ./sage -coverage devel/sage-test/sage/rings/arith.py produces
----------------------------------------------------------------------
devel/sage-test/sage/rings/arith.py
ERROR: Please add a `TestSuite(s).run()` doctest.
SCORE devel/sage-test/sage/rings/arith.py: 100% (89 of 89)
----------------------------------------------------------------------
It scores a 100% but should we worry about the "ERROR" above?
Anyway, I leave it as positive_review. And I hope someone can educate me
on item 2) and 3) above. Thanks.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11750#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
