#11749: Remove unneeded imports
-------------------------------------------+--------------------------------
Reporter: robertwb | Owner: tbd
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: performance | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Keshav Kini, Leif Leonhardy | Author: Robert Bradshaw
Merged: | Dependencies:
-------------------------------------------+--------------------------------
Changes (by leif):
* reviewer: Keshav Kini => Keshav Kini, Leif Leonhardy
Comment:
''Ooops. I wrote this a few hours ago, but forgot to click the submit
button.''
Replying to [comment:7 robertwb]:
> I generated the patch with this code, plus a handful (less than a dozen)
manual touch-ups where, e.g., symbols were used in eval() strings but not
directly.
Ok, so it is rather conservative with the exception of `eval()` and
friends.
We should perhaps especially inspect those files modified that have a low
"coverage"(though I strongly doubt the doctests of others will cover most
execution paths...).
I think more sophisticated detection of superfluous imports can be left
for follow-up tickets, just like the inclusion of Cython files.
The patch is certainly a big step forwards as is.
----
P.S.: I'm pretty sure Robert knows about trac's wiki markup for source
code etc. ;)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11749#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
