#11772: improving error reporting of random_matrix
------------------------------+---------------------------------------------
Reporter: dimpase | Owner: jason, was
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-4.7.2
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Rob Beezer | Author:
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by rbeezer):
* reviewer: => Rob Beezer
Old description:
> The error message of the call to random_matrix(QQ, 4, 8, rank=5) is quite
> cryptic.
> It should be easy to check that the rank is greater than min(nrows,ncols)
> and throw a ValueError with a meaningful message.
>
> A patch, which also fixes a similar small fly in random_subspaces_matrix,
> is attached.
New description:
The error message of the call to random_matrix(QQ, 4, 8, rank=5) is quite
cryptic.
It should be easy to check that the rank is greater than min(nrows,ncols)
and throw a ValueError with a meaningful message.
A patch, which also fixes a similar small fly in random_subspaces_matrix,
is attached.
'''Apply''':
1. [attachment:trac_11772-v2.patch]
1. [attachment:trac_11772-doctests.patch]
--
Comment:
v2-patch is Dima's original, but with a Trac number in the commit message.
There was one doctest failure on the subspace routine (the fly), since
`None` is an allowed value for the rank, and it seems `None < 0` is
`True`. I moved a hunk of code that checks the `rank=None` case to happen
early, and removed a pointless else-clause.
I like doctests that exercise error-conditions, so I added 3 new doctests.
Original patch is a positive review from me, whoever wants to review my
patch (Dima?) can flip this whole ticket to positive review if my patch is
OK.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11772#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
