#11738: Various issues in is_interval and is_chordal
----------------------------+-----------------------------------------------
Reporter: ddestrada | Owner: jason, ncohen, rlm
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7.2
Component: graph theory | Keywords: interval chordal
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
----------------------------+-----------------------------------------------
Changes (by ncohen):
* status: new => needs_review
Old description:
> There is a bug in the return line of is_interval when asked for a
> certificate and the graph has more than one connected component.
>
> Also, here there is an enhancement to avoid the explicit generation of
> subsets in is_interval and is_chordal, which is expensive, using
> issubset() instead.
New description:
There is a bug in the return line of is_interval when asked for a
certificate and the graph has more than one connected component.
Also, here there is an enhancement to avoid the explicit generation of
subsets in is_interval and is_chordal, which is expensive, using
issubset() instead.
(This ticket should be coordinated with #11735)
--
Comment:
Hellooooo Diego !
I just tried to aply your patches, and noticed a small problem : you
worked on files located in the build/ directory, and those files we usully
do not touch (they are not even tracked by HG). When you modify Sage's
sources, you should work in the sage/ folder instead of the build/ folder,
and modifyth corresponding files. Then, when you load Sage, you should
type "sage -br branch_name" to let it know that some files have been
modified. As they are made right now, your patches modify files that will
be overwritten when Sage is rebuilt `:-)`
Then, I noticed that you were reversing the default order of the lex-BFS
tree. That's a default choice, so I do not think it makes much of a
difference, but I was worried that it may break doctests in Sage. All the
examples of code you see in Sage's documentation are actually automated
tests that let us check our modifications to not create new bugs. It's
dead useful, but it also means that when you reverse this kind of ordering
one of the doctest may expect 1 2 3 4 5 and receive 5 4 3 2 1 `:-)`
Then again, I did not test this because of the "build/" thing `:-)`
http://www.sagemath.org/doc/developer/doctesting.html
Nathann
P.S. : Oh, and do nt forget to set the Trac ticket's status to
needs_review when necessary, otherwise it does not appear in thelist of
tickets needing care and they can be forgotten forever this way ! (some of
my tickets disappeared for a few months because of such a mistake before)
`:-)`
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11738#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
