#11738: Various issues in is_interval and is_chordal
-----------------------------+----------------------------------------------
Reporter: ddestrada | Owner: jason, ncohen, rlm
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7.2
Component: graph theory | Keywords: interval chordal
Work_issues: | Upstream: N/A
Reviewer: Nathann Cohen | Author: Diego de Estrada
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
* author: => Diego de Estrada
Old description:
> There is a bug in the return line of is_chordal when asked for a
> certificate and the graph has more than one connected component.
>
> Also, here there is an enhancement to avoid the explicit generation of
> subsets in is_interval and is_chordal, which is expensive, using
> issubset() instead.
>
> (This ticket should be coordinated with #11735)
New description:
There is a bug in the return line of is_chordal when asked for a
certificate and the graph has more than one connected component.
Also, here there is an enhancement to avoid the explicit generation of
subsets in is_interval and is_chordal, which is expensive, using
issubset() instead.
(This ticket should be coordinated with #11735)
Apply only :
* [attachment:trac_11738.patch]
--
Comment:
Hello Diego !
Thank you for your modifications ! `:-)`
While reviewing your patches I folded them into a unique one, so that it
will be easier for the release manager to merge. It passed all tests and
fixed some of my mistakes, thank you very much for it !
I will shortly update #11735 so that it can be applied on top of this
patch, and quickly fix the current bug (by the way, if you are willing to
review #11735 after that.. `:-D`). Another patch will follow #11735 as a
result of the discussion with Jan mentionned there. At least with #11735
we will have a "sounder" version implementation, no danger of having a bad
result returned, but that will have to be patched too `:-)`
It's getting fixed, guys !!!!
(and thank you again !)
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11738#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
