#9138: Categories for all rings
---------------------------------------------------------------------+------
Reporter: jbandlow |
Owner: nthiery
Type: defect |
Status: needs_review
Priority: major |
Milestone: sage-4.7.2
Component: categories |
Keywords: introspection, categories for rings
Work_issues: comparison of BooleanPolynomialRings; one doctest fix |
Upstream: N/A
Reviewer: |
Author: Simon King
Merged: |
Dependencies: sage-4.7, #11268, #11139, #9976, #9944, #11269, #11316, #11342
---------------------------------------------------------------------+------
Comment(by vbraun):
The doctests pass for me, too.
When I see commented-out methods lying around then I usually assume that
they should be IN but for some reason we can't add the code yet, or that
there is a bug in them that ought to be fixed. But right now there are
various places where its just old stuff that we should actually get rid
of. I would very much appreciate if you could clean that up and remove
instead of just commenting out code that is not relevant any more.
Realistically, if we don't remove that stuff while refactoring for newer
frameworks then it'll forever clutter the source files. For those
interested in the history there is always mercurial...
Some comments on the first patch:
* There is also a commented-out `__cmp__` in
`sage/rings/polynomial/infinite_polynomial_ring.py`, I take it that should
be removed as well?
* `sage/rings/ring.pyx` l. 356-360 some commented out stuff after
return? Same file, there are two `category()` methods that are just
commented out.
Second patch:
* `sage/algebras/free_algebra_quotient.py` the `_coerce_impl` and
`__contains__` methods are also old stuff that should be snipped now that
its no longer used.
* The `_mul_(self,y)` method in `sage/monoids/free_monoid_element.py`
guarantees `y` to be a `FreeModuleElement` so the commented-out isinstance
check should be removed.
* `sage/monoids/monoid.py` again superfluous `category()` method already
commented out.
* The commented-out `__reduce__` method in
`sage/rings/polynomial/pbori.pyx` should go away, right?
* The added comments in `sage/rings/quotient_ring.py` l. 153-162 aren't
very helpful IMHO.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9138#comment:103>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
