#9739: Handle duplicate file basenames when testing multiple files in parallel
-----------------------------------------------+----------------------------
Reporter: mpatel | Owner: mvngu
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-4.7.2
Component: doctest | Keywords: doctest
scripts
Work_issues: | Upstream: N/A
Reviewer: Robert Bradshaw, Leif Leonhardy | Author: Mitesh Patel,
John Palmieri
Merged: | Dependencies:
-----------------------------------------------+----------------------------
Comment(by leif):
Replying to [comment:72 jhpalmieri]:
> What still needs to be done here? [[BR]]
> [[BR]]
> Replying to [comment:70 leif]:
> > Replying to [comment:68 jhpalmieri]:
> > > Replying to [comment:67 leif]:
> > > > I'd prefer `sage-doctest`'s PID, appended (separated by an
underscore) as [comment:62 above].
> I can remove the pathname from the mangling. If we're just adding the
pid, I may discard the function `filename_mangler` and deal with it like
this:
{{{
#!diff
- f = os.path.splitext(filename_mangler(file))[0] + '.py'
+ f = os.path.join(SAGE_TESTDIR, "doctest_%s_%s.py" % (os.getpid(),
name))
}}}
I'd prefer having the name first, then the PID; then we can also drop the
`doctest_` prefix (because e.g. `1_module` is not a valid Python module
name).
I think this way it's easier to locate a file (with `ls` or some file
manager), since the files will be in alphabetical order, sorted by their
original name (as opposed to some random PIDs).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9739#comment:74>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
