#9739: Handle duplicate file basenames when testing multiple files in parallel
-----------------------------------------------+----------------------------
Reporter: mpatel | Owner: mvngu
Type: defect | Status:
positive_review
Priority: blocker | Milestone: sage-4.7.2
Component: doctest | Keywords: doctest
scripts race condition unique filenames ptestlong -tp
Work_issues: | Upstream: N/A
Reviewer: Robert Bradshaw, Leif Leonhardy | Author: Mitesh Patel,
John Palmieri
Merged: | Dependencies:
-----------------------------------------------+----------------------------
Changes (by leif):
* keywords: doctest scripts => doctest scripts race condition unique
filenames ptestlong -tp
* status: needs_review => positive_review
Comment:
Sorry for the delay.
I started testing the v2 yesterday, also with `make testlong`, which took
ages, the latter unfortunately right before you made the v3, and later
made a mistake when wanting to test v3, retesting v2 again... 8/
I've now also tested v3, with both sequential doctests (since we've
modified `sage-doctest`, but not yet `sage-test`, except for a comment),
and parallel tests with up to 128 threads.
I've reviewed the code already, so I can -- hopefully finally -- give this
a '''positive review'''. (At least until something unexpected happens; I
must admit I haven't tested the latest versions with non-library code
yet.)
Thanks for spending so much time on this.
[[BR]]
Replying to [comment:85 jhpalmieri]:
> Replying to [comment:83 leif]:
> > I think we should create the same temporary directory
(`$SAGE_TESTDIR/$hostname-$pid`) in `sage-test` as well (on this ticket),
and export this in `SAGE_TESTDIR` for `sage-doctest`.
> >
> > Also wouldn't be bad to put such common code into a separate module,
before we "unify" (or unite) `sage-test` and `sage-ptest`.
>
> These both sound like issues for #9224, not here.
Well, Dave wanted this (the former), at least when we started here last
year... ;-)
I've added a comment there w.r.t. also using unique directories when
testing sequentially, since there might be multiple instances running at
the same time.
[[BR]]
> I really don't want to add any more to this ticket unless there is an
extremely good reason to do so.
Ok, agreed. This ticket has really been dragging enough.
[[BR]]
By the way, you were right; `opts` is a ''string'' (of the concatenated
options) there, as opposed to a list of strings, so `"-verbose" in opts`
would have been enough. But it works this way, too, and is IMHO nothing
worth fixing again ''here''.
Also, or on the other hand, I don't think anybody will ever use
`--verbose` when doctesting in parallel, since the output would be totally
messed up, unless one uses `sage -tp 1 ...` (or `make NUM_THREADS=1 ...`,
which is also useful in some cases.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9739#comment:86>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
