#4539: plural wrapper
---------------------------+------------------------------------------------
   Reporter:  burcin       |          Owner:  OleksandrMotsak, AlexanderDreyer
       Type:  enhancement  |         Status:  needs_work                      
   Priority:  major        |      Milestone:  sage-4.7.2                      
  Component:  algebra      |       Keywords:  libsingular plural wrapper sd34 
Work_issues:               |       Upstream:  N/A                             
   Reviewer:               |         Author:                                  
     Merged:               |   Dependencies:  #7797 #11316 #11856             
---------------------------+------------------------------------------------

Comment(by SimonKing):

 Concerning [attachment:trac4539_monomial_quotient.patch]: I am not sure if
 it is the right thing to do. I think that monomial_quotient is a method
 that should be as fast as possible, since in some situations it is used
 very frequently. In these situations, it is always the case that one
 monomial ''does'' divide the other. Hence, for the application, it is a
 bad idea to have a redundant sanity test in monomial_quotient. I'd rather
 have it return a wrong result when using it in a wrong way.

 Note that [attachment:trac4539_kwds.patch] is not needed for my patch - I
 already have *args in it.

 We have already briefly discussed why I think that
 [attachment:trac4539_lmul.patch] probably is not a good approach:
 x._rmul_(c) and x._lmul_(c) (by specification of the coercion model) can
 assume that the argument c belongs to x.parent().base_ring(). In
 particular, I don't believe that c can actually be a non-commutative
 polynomial.

 Can you please provide an example that was segfaulting without the lmul-
 patch?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4539#comment:59>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to