#10903: Update Singular to 3-1-3-3.
---------------------------------------------+------------------------------
   Reporter:  malb                           |          Owner:  tbd             
                            
       Type:  defect                         |         Status:  positive_review 
                            
   Priority:  critical                       |      Milestone:  sage-4.7.2      
                            
  Component:  packages                       |       Keywords:  singular 
SageDays34 sd34                    
Work_issues:                                 |       Upstream:  N/A             
                            
   Reviewer:  Martin Albrecht, Volker Braun  |         Author:  Burcin Erocal, 
Martin Albrecht, Volker Braun
     Merged:                                 |   Dependencies:  #11339          
                            
---------------------------------------------+------------------------------

Comment(by leif):

 Did someone check the compiler warnings for the Singular spkg?

 Especially "''always false''" and "''may be used uninitialized''" are
 scary:

 {{{
 cf_factor.cc:440: warning: comparison is always false due to limited range
 of data type
 cf_factor.cc:467: warning: comparison is always false due to limited range
 of data type
 facBivar.cc:213: warning: ‘evaluation2’ may be used uninitialized in this
 function
 facBivar.cc:213: warning: ‘evaluation’ may be used uninitialized in this
 function
 facFactorize.cc:322: warning: ‘lev’ may be used uninitialized in this
 function
 facFqBivar.cc:594: warning: ‘m’ may be used uninitialized in this function
 facFqBivar.cc:594: warning: ‘i’ may be used uninitialized in this function
 facFqBivarUtil.cc:215: warning: ‘degMipoBeta’ may be used uninitialized in
 this function
 facFqFactorize.cc:1495: warning: ‘lev’ may be used uninitialized in this
 function
 sm_sparsemod.cc:113: warning: ‘N’ may be used uninitialized in this
 function
 cf_factor.cc:440: warning: comparison is always false due to limited range
 of data type
 cf_factor.cc:467: warning: comparison is always false due to limited range
 of data type
 cf_factor.cc:440: warning: comparison is always false due to limited range
 of data type
 cf_factor.cc:467: warning: comparison is always false due to limited range
 of data type
 facBivar.cc:213: warning: ‘evaluation2’ may be used uninitialized in this
 function
 facBivar.cc:213: warning: ‘evaluation’ may be used uninitialized in this
 function
 facFactorize.cc:322: warning: ‘lev’ may be used uninitialized in this
 function
 facFqBivar.cc:594: warning: ‘m’ may be used uninitialized in this function
 facFqBivar.cc:594: warning: ‘i’ may be used uninitialized in this function
 facFqBivarUtil.cc:215: warning: ‘degMipoBeta’ may be used uninitialized in
 this function
 facFqFactorize.cc:1495: warning: ‘lev’ may be used uninitialized in this
 function
 sm_sparsemod.cc:113: warning: ‘N’ may be used uninitialized in this
 function
 cf_factor.cc:440: warning: comparison is always false due to limited range
 of data type
 cf_factor.cc:467: warning: comparison is always false due to limited range
 of data type
 canonicalform.cc:1744: warning: deprecated conversion from string constant
 to ‘char*’
 canonicalform.cc:1750: warning: deprecated conversion from string constant
 to ‘char*’
 cf_factor.cc:440: warning: comparison is always false due to limited range
 of data type
 cf_factor.cc:467: warning: comparison is always false due to limited range
 of data type
 facBivar.cc:213: warning: ‘evaluation2’ may be used uninitialized in this
 function
 facBivar.cc:213: warning: ‘evaluation’ may be used uninitialized in this
 function
 facFactorize.cc:322: warning: ‘lev’ may be used uninitialized in this
 function
 facFqBivar.cc:594: warning: ‘m’ may be used uninitialized in this function
 facFqBivar.cc:594: warning: ‘i’ may be used uninitialized in this function
 facFqBivarUtil.cc:215: warning: ‘degMipoBeta’ may be used uninitialized in
 this function
 facFqFactorize.cc:1495: warning: ‘lev’ may be used uninitialized in this
 function
 /usr/include/c++/4.2/backward/backward_warning.h:32:2: warning: #warning
 This file includes at least one deprecated or antiquated header. Please
 consider using one of the 32 headers found in section 17.4.1.2 of the C++
 standard. Examples include substituting the <X> header for the <X.h>
 header for C++ includes, or <iostream> instead of the deprecated header
 <iostream.h>. To disable this warning use -Wno-deprecated.
 sm_sparsemod.cc:113: warning: ‘N’ may be used uninitialized in this
 function
 readcf.cc:1452: warning: deprecated conversion from string constant to
 ‘char*’
 readcf.cc:1598: warning: deprecated conversion from string constant to
 ‘char*’
 canonicalform.cc:1744: warning: deprecated conversion from string constant
 to ‘char*’
 canonicalform.cc:1750: warning: deprecated conversion from string constant
 to ‘char*’
 cf_factor.cc:440: warning: comparison is always false due to limited range
 of data type
 cf_factor.cc:467: warning: comparison is always false due to limited range
 of data type
 /usr/include/c++/4.2/backward/backward_warning.h:32:2: warning: #warning
 This file includes at least one deprecated or antiquated header. Please
 consider using one of the 32 headers found in section 17.4.1.2 of the C++
 standard. Examples include substituting the <X> header for the <X.h>
 header for C++ includes, or <iostream> instead of the deprecated header
 <iostream.h>. To disable this warning use -Wno-deprecated.
 memutil.c:98: warning: implicit declaration of function ‘memcpy’
 memutil.c:98: warning: incompatible implicit declaration of built-in
 function ‘memcpy’
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10903#comment:59>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to