#10970: Do not generate pipestatus from spkg/install
----------------------------+-----------------------------------------------
Reporter: vbraun | Owner: GeorgSWeber
Type: defect | Status: needs_info
Priority: minor | Milestone: sage-4.7.2
Component: build | Keywords: sd32
Work_issues: | Upstream: N/A
Reviewer: Mariah Lenox | Author: Volker Braun
Merged: | Dependencies:
----------------------------+-----------------------------------------------
Old description:
> The `$SAGE_ROOT/spkg/install` has a here document that creates
> `pipestatus`. With the sage root repository, this is no longer needed as
> `pipestatus` is tracked by the repository. The patch removes it from
> `$SAGE_ROOT/spkg/install`.
>
> ----
>
> Apply [attachment:trac_10970_do_not_generate_pipestatus.patch] to the
> Sage '''root repository''' (in `$SAGE_ROOT`).
>
> ----
>
> '''If this ticket gets merged, the change should be prominently announced
> in the release notes.'''
New description:
The `$SAGE_ROOT/spkg/install` has a here document that creates
`pipestatus`. With the sage root repository, this is no longer needed as
`pipestatus` is tracked by the repository. The patch removes it from
`$SAGE_ROOT/spkg/install`.
----
Apply [attachment:trac_10970_do_not_generate_pipestatus.patch] and
[attachment:trac_10970-error-msg.patch] to the Sage '''root repository'''
(in `$SAGE_ROOT`).
----
'''If this ticket gets merged, the change should be prominently announced
in the release notes.'''
--
Comment(by jhpalmieri):
I'm attaching a referee patch printing an error message if `pipestatus` is
missing. We could also patch the scripts repo:
{{{
#!diff
diff --git a/sage-update b/sage-update
--- a/sage-update
+++ b/sage-update
@@ -400,6 +400,8 @@ def do_update():
os.chdir(SPKG_ROOT)
download_file("install")
os.system('chmod +x install')
+ download_file("pipestatus")
+ os.system('chmod +x pipestatus')
os.chdir(os.path.join(SPKG_ROOT, "standard"))
download_file("standard/deps")
download_file("standard/newest_version")
@@ -408,6 +410,7 @@ def do_update():
os.chdir(SAGE_ROOT)
if root_repo_intact:
for file in ['spkg/install',
+ 'spkg/pipestatus',
'spkg/standard/deps',
'spkg/standard/newest_version']:
subprocess.call('./sage -hg commit %s -m ' % file +
}}}
but I'm not sure it's worth it: `pipestatus` is not a script which should
change a lot, so if you have an out-of-date version, it's probably good
enough, and it will get replaced during the upgrade process and used the
next time around.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10970#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
