#10903: Update Singular to 3-1-3-3.
---------------------------------------------------------+------------------
Reporter: malb | Owner: tbd
Type: defect | Status:
positive_review
Priority: critical | Milestone:
sage-4.7.2
Component: packages | Keywords:
singular SageDays34 sd34
Work_issues: | Upstream: N/A
Reviewer: Martin Albrecht, Volker Braun, Simon King | Author:
Burcin Erocal, Martin Albrecht, Volker Braun, Simon King
Merged: | Dependencies:
#11339
---------------------------------------------------------+------------------
Changes (by SimonKing):
* status: needs_review => positive_review
* reviewer: Martin Albrecht, Volker Braun => Martin Albrecht, Volker
Braun, Simon King
Comment:
Replying to [comment:85 vbraun]:
> I'm happy with trac10903_lgamma_doc.patch. Maybe Simon can quickly OK
the trac_10903_docbuild_fix.patch, then we would be good to go?
Sorry, I forgot to post before leaving office: Your patch manages to
deduce the name of a deprecated Cython method. That certainly fixes the
problem with the docs. With the patches applied as you stated it in the
modified ticket description, both the doc tests and the references are
fine.
Thus, positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10903#comment:86>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
