#10903: Update Singular to 3-1-3-3
-------------------------------------------------------------------------+--
Reporter: malb |
Owner: tbd
Type: defect |
Status: needs_review
Priority: critical |
Milestone: sage-4.7.2
Component: packages |
Resolution:
Keywords: singular SageDays34 sd34 |
Work_issues:
Upstream: N/A |
Reviewer: Martin Albrecht, Volker Braun, Simon King
Author: Burcin Erocal, Martin Albrecht, Volker Braun, Simon King |
Merged: sage-4.7.2.alpha4
Dependencies: #11339 |
-------------------------------------------------------------------------+--
Comment(by leif):
Replying to [comment:108 jdemeyer]:
> New spkg needs review:
[http://boxen.math.washington.edu/home/jdemeyer/spkg/singular-3-1-3-3.p1.spkg].
See [attachment:singular-3-1-3-3.p0-p1.diff] for changes.
{{{
* Exit when `patch` fails. We do not print an error message, patch is
verbose enough by itself.
}}}
Not true. `patch`'s error messages do not start with `Error` nor `Failed`,
such that it's hard to find out which spkg actually failed to build /
install in parallel builds.
If you don't want to apply the patches in a loop (prepending numbers to
[some of] the patches could force the proper order), you should use
something like
{{{
#!sh
patch_error()
{
echo >&2 "Error: Patch failed to apply."
exit 1
}
...
patch -p1 < ... || patch_error
...
}}}
or use the weirdly-named `success()` function.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10903#comment:110>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
