#8776: notebook: sage notebook undo doesn't really work, due to not enough (=no)
automatic snapshots, or other bugs
------------------------+---------------------------------------------------
   Reporter:  was       |          Owner:  jason, was                           
    
       Type:  defect    |         Status:  new                                  
    
   Priority:  major     |      Milestone:  sage-4.7.2                           
    
  Component:  notebook  |       Keywords:                                       
    
Work_issues:            |       Upstream:  Reported upstream. Little or no 
feedback.
   Reviewer:            |         Author:                                       
    
     Merged:            |   Dependencies:                                       
    
------------------------+---------------------------------------------------

Comment(by schymans):

 Thanks, Jason!

 I did as you said and the result was as predicted: the patch failed to
 apply, but maybe for the wrong reasons again. Does the following error
 message help?

 {{{
 sage: hg_sage.apply("/home/uname/Downloads/sage/trac_8776-sagenb-
 undo.2.patch")
 applying /home/uname/Downloads/sage/trac_8776-sagenb-undo.2.patch
 unable to find 'sagenb/notebook/worksheet.py' for patching
 3 out of 3 hunks FAILED -- saving rejects to file
 sagenb/notebook/worksheet.py.rej
 abort: patch failed to apply
 cd "/home/uname/Programs/sage-test/devel/sage" && hg status
 cd "/home/uname/Programs/sage-test/devel/sage" && hg status
 cd "/home/uname/Programs/sage-test/devel/sage" && hg import
 "/home/uname/Downloads/sage/trac_8776-sagenb-undo.2.patch"

 }}}
 /home/uname/Programs/sage-test is my sage directory, in which I created a
 clone called sage-test. I tried to apply the patch to the clone, which
 should be in /home/uname/Programs/sage-test/devel/sage-test/..., but there
 is indeed no worksheet.py.

 I found worksheet.py in ~/Programs/sage-test/devel/sagenb/sagenb/notebook/
 (note the nested sagenb/sagenb/), whereas the directory ~/Programs/sage-
 test/devel/sage-test/sagenb/notebook/ in my sandbox only contains
 worksheet.py.rej. There is also no ~/Programs/sage-test/devel/sage-
 test/sagenb/sagenb/, so the clone does not seem to have the same directory
 structure as the original. Anyway, even if I try to apply the patch to the
 main branch, I get the same error message, probably because it is looking
 in devel/sagenb/notebook/ and not in devel/sagenb/sagenb/notebook/. I'm
 confused.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8776#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to