#11942: segfault on Graph().connected_component_containing_vertex('')
----------------------------+-----------------------------------------------
   Reporter:  kini          |          Owner:  jason, ncohen, rlm
       Type:  defect        |         Status:  needs_review      
   Priority:  major         |      Milestone:  sage-4.7.3        
  Component:  graph theory  |       Keywords:                    
Work_issues:                |       Upstream:  N/A               
   Reviewer:  Keshav Kini   |         Author:  Nathann Cohen     
     Merged:                |   Dependencies:                    
----------------------------+-----------------------------------------------
Changes (by kini):

  * reviewer:  => Keshav Kini


Comment:

 Wow, that was fast! :D I have a couple of questions, though.
 `Graph().connected_component_containing_vertex(0)` already produces an
 exception, which includes the number 0 in the message. This is still true
 with your patch. Currently investigating why...

 Also, your exception is a `ValueError` - shouldn't it be a `KeyError`?
 Shouldn't the current error for vertex `0` be a `KeyError` too instead of
 a (!?) `RuntimeError`? The
 [http://docs.python.org/library/exceptions.html#exceptions.Exception
 Python docs] say:

 > This exception is mostly a relic from a previous version of the
 interpreter; it is not used very much any more.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11942#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to