#11942: segfault on Graph().connected_component_containing_vertex('')
------------------------------------------+---------------------------------
   Reporter:  kini                        |          Owner:  jason, ncohen, rlm
       Type:  defect                      |         Status:  needs_work        
   Priority:  major                       |      Milestone:  sage-4.8          
  Component:  graph theory                |       Keywords:                    
Work_issues:                              |       Upstream:  N/A               
   Reviewer:  Keshav Kini, David Coudert  |         Author:  Nathann Cohen     
     Merged:                              |   Dependencies:                    
------------------------------------------+---------------------------------
Changes (by kini):

  * status:  positive_review => needs_work


Comment:

 Please read the comments. The ValueError needs to be changed to KeyError,
 and also I wanted to understand the following before giving it a positive
 review, as possibly the fix could be improved (multiple code paths for a
 single purpose is bad design):

 >`Graph().connected_component_containing_vertex(0)` already produces an
 exception, which includes the number 0 in the message. This is still true
 with your patch.

 Sorry for neglecting this ticket for so long.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11942#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to