#5852: Properly canonicalize $SAGE_ROOT
-------------------------------+--------------------------------------------
    Reporter:  tornaria        |         Owner:  jdemeyer    
        Type:  defect          |        Status:  needs_review
    Priority:  major           |     Milestone:  sage-4.7.3  
   Component:  scripts         |    Resolution:              
    Keywords:                  |   Work_issues:              
    Upstream:  N/A             |      Reviewer:              
      Author:  Jeroen Demeyer  |        Merged:              
Dependencies:                  |  
-------------------------------+--------------------------------------------

Comment(by leif):

 What sense does it make to first call `resolvelinks()` and then finally do
 {{{
 #!sh
 SAGE_ROOT=`cd "$SAGE_ROOT" && pwd -P`
 }}}
 ?

 Also, why use all of `[ "x$foo" != "x" ]` (causing eye cancer), `[ -n
 "$foo" ]` and `[ "$foo" != "" ]`?

 For `sage` at least, or any script that's run by `bash`, `[[ -n $foo ]]`
 or `[[ $foo != "" ]]` does the job, and is by the way both safer and
 faster.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5852#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to