#11884: Fix ECL so it builds on OS X Lion
------------------------------+---------------------------------------------
   Reporter:  jhpalmieri      |          Owner:  tbd                            
       
       Type:  defect          |         Status:  needs_review                   
       
   Priority:  major           |      Milestone:  sage-4.7.2                     
       
  Component:  packages        |       Keywords:  ecl spkg upgrade update lion 
darwin 11
Work_issues:                  |       Upstream:  N/A                            
       
   Reviewer:  Leif Leonhardy  |         Author:  William Stein                  
       
     Merged:                  |   Dependencies:  #11966                         
       
------------------------------+---------------------------------------------

Comment(by leif):

 Replying to [comment:24 jhpalmieri]:
 > By the way, I deleted the directory src/src/libffi directory, and this
 gives a warning during configuration [...] [[BR]]
 > [[BR]]
 > I wonder if we should configure using `--with-dffi=no` on all platforms?
 Or perhaps I shouldn't delete the directory.

 `libffi` is installed on many systems, so we certainly shouldn't disable
 it.

 [[BR]]

 >
 {{{
 $ du -s -h src
 44M     src
 $ du -s -h src/src/libffi/
 7.2M    src/src/libffi/
 }}}
 > So it takes a fair amount of room...

 Much more worth is (also) removing the `gmp` directory, which at the
 moment makes up half of the tarball; see #9493.  One should at least add a
 `TODO`, since people apparently tend to not look at other related tickets.

 [[BR]]

 If you configure with `--enable-unicode=no` (you could also use
 `--disable-unicode` btw.), you can completely remove the following two
 directories (not just their contents):
 {{{
 src/contrib/encodings/
 src/contrib/unicode/
 }}}

 [[BR]]

 If the patches are applied from `src/`, they should be applied (i.e., be
 appliable) with `-p1` for consistency.

 I also get
 {{{
 patching file src/c/ffi/libraries.d
 Hunk #1 succeeded at 70 with fuzz 2 (offset 1 line).
 }}}

 [[BR]]

 `spkg-install` in whole needs some clean-up, for example all error
 messages should go to `stderr`.  If `MAKEFLAGS` are a problem on MacOS X,
 they should be unset on MacOS X, not by default (and the comment is btw.
 wrong or unrelated).  We do not create a symbolic link to the ECL library,
 but the ECL library directory, so the error message is wrong. ...

 ----

 Ceterum censeo we should upgrage trac.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11884#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to