#11926: "make" should run Sage once
-------------------------------------------+--------------------------------
    Reporter:  jdemeyer                    |         Owner:  GeorgSWeber        
          
        Type:  defect                      |        Status:  closed             
          
    Priority:  major                       |     Milestone:  sage-4.8           
          
   Component:  build                       |    Resolution:  fixed              
          
    Keywords:  Makefile build sage-starts  |   Work_issues:                     
          
    Upstream:  N/A                         |      Reviewer:  John Palmieri, 
Leif Leonhardy
      Author:  Jeroen Demeyer              |        Merged:  sage-4.8.alpha0    
          
Dependencies:                              |  
-------------------------------------------+--------------------------------

Comment(by leif):

 Replying to [comment:81 jdemeyer]:
 > Replying to [comment:80 leif]:
 > > But still `doc` should depend on `start`, such that one immediately
 gets ''a single, meaningful'' error message
 > I don't find it logical that `doc` would depend on `start`.  I still
 think the best solution would be to have `make build` run `sage-starts`.
 So here, we have to agree to disagree.

 The builder imports `sage.all`, hence `doc` requires that Sage can start.

 Perhaps `sage --docbuild` should check once that it is functional (with
 `try: import sage.all ...`).


 [[BR]]

 > If we are not allowed to make patches just because some other ticket
 makes changes to the same code, then we might as well stop Sage
 development.  Especially if the ticket gets "dragged" as you say.

 I was talking about ''unnecessary'', unrelated changes.  Any developer
 should at least be aware of other tickets touching the same code.

 It's also bad practice to bundle unrelated changes to different files into
 a single patch, just because they're in the same repo.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11926#comment:83>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to