#12016: parallelism in Sage: just use value of 'MAKE'
---------------------------+------------------------------------------------
Reporter: jhpalmieri | Owner: GeorgSWeber
Type: enhancement | Status: needs_work
Priority: critical | Milestone: sage-4.8
Component: build | Keywords:
Work_issues: | Upstream: N/A
Reviewer: | Author: John Palmieri, Jeroen Demeyer
Merged: | Dependencies: #11969
---------------------------+------------------------------------------------
Comment(by jhpalmieri):
Replying to [comment:12 jdemeyer]:
> 1) If you are going to use the string "auto" for automatic, you might as
well use "infinite" for infinite, instead of zero.
>
> 1b) Alternatively: use 0 for automatic (as is sage -tp 0) and 999999 for
unlimited. This would mean less special-case code, since a value like
999999 is more than what a user would normally specify (for the forseeable
future).
Sounds good to me.
> 2) In `sage-ptest`, unlimited really should be unlimited. Not max(8, #
of cpus).
Okay.
> 3) We should also do the following long-needed fix here: setting `MAKE`
to `make -j16` is very standard in Sage circles, but not actually the
prefered way according to the GNU make folks. One really should use
`MAKEFLAGS` instead (similar to the distinction between `CC` and
`CFLAGS`). This is why you often see an error like "make -jN forced in
sub-make. Disabling job server mode" (freely quoted from my mind). So,
when `MAKEFLAGS` exists, assume that make understands the flags and '''do
not pass flags''' in `MAKE`.
I'm willing to try that, especially if you write the patch instead of me
:)
> 4) Why did you change
> {{{
> sage-build "$@" || exit $?
> }}}
> to
> {{{
> sage-build "$@"
> }}}
> in the `sage_build()` function in `sage-sage`?
That was a mistake.
> 5) You reverted a lot of changes that I made to
`doc/en/developer/doctesting.rst`. Why? I actually '''tried''' all the
examples in the documentation and pasted the exact output I got (on
`sage.math.washington.edu`). Surely, this is better than keeping the
outdated (and in many cases totally wrong) output.
Some of them I disagreed with, like the complete removal of the section
"Beyond the Sage library". So I started from scratch, at which point I
just put in the changes that I felt were relevant to the ticket or easy
for me to change. Probably I should have started with your patch and
added the section (with modifications) back in.
It looks like #9739 broke doctesting of .sage files. We should fix that
(not on this ticket).
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/12016#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
