#10973: Integral points on elliptic curves over number fields
-------------------------------+--------------------------------------------
Reporter: justin | Owner: cremona
Type: enhancement | Status: positive_review
Priority: major | Milestone:
Component: elliptic curves | Keywords: sd32
Work_issues: | Upstream: N/A
Reviewer: | Author: Justin Walker, Aly Deines,
Jennifer Balakrishnan
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Changes (by cremona):
* status: needs_review => positive_review
Old description:
> Incorporate work done by Rado Kirov and Jackie Anderson at Sage Days 22,
> based on Magma implementation by Cremona's student Nook.
New description:
Incorporate work done by Rado Kirov and Jackie Anderson at Sage Days 22,
based on Magma implementation by Cremona's student Nook.
Apply only Trac10973.7.patch
--
Comment:
Positive review. In my reviewer's patch I fix the following:
0. Now applies to 4.7.2 with no fuzz.
1. Added QQ to import list on line 332 of ell_number_field.py,
otherwise testing ell_int_pts failed, but testing ell_number_field did not
-- since the test for that function silverman_height_bounds was
incomplete! I fixed that too.
2. Fixed a warning in docbuild by adding a blank line at line 69 of
the same file.
It is now true that for an elliptic curve E over Q we have both the new
E.silverman_height_bounds(), which gives lower and upper bounds, and the
old E.silverman_height_bound(), which only gives one of them. The latter
can be deleted but that will require some tweaking of any code which uses
it. I have left that for another ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10973#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
