#10973: Integral points on elliptic curves over number fields
-------------------------------+--------------------------------------------
   Reporter:  justin           |          Owner:  cremona                       
                  
       Type:  enhancement      |         Status:  needs_work                    
                  
   Priority:  major            |      Milestone:  sage-4.8                      
                  
  Component:  elliptic curves  |       Keywords:  sd32                          
                  
Work_issues:                   |       Upstream:  N/A                           
                  
   Reviewer:  John Cremona     |         Author:  Justin Walker, Aly Deines, 
Jennifer Balakrishnan
     Merged:                   |   Dependencies:                                
                  
-------------------------------+--------------------------------------------
Changes (by jdemeyer):

  * status:  positive_review => needs_work


Comment:

 I unfortunately get several doctest failures (with sage-4.8.alpha2 +
 various patches).  Did you test this patch with the new PARI (merged in
 sage-4.8.alpha1)?  I am also afraid that there are speed regressions, I am
 seeing a timeout:
 {{{
 sage -t  -force_lib
 devel/sage/sage/schemes/elliptic_curves/ell_int_points.py
 **********************************************************************
 File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.8.alpha3/devel/sage-
 main/sage/schemes/elliptic_curves/ell_int_points.py", line 12:
     sage: E.integral_points()
 Expected:
     [(-11 : -19 : 1), (-2 : 29 : 1), (4 : -16 : 1), (13 : -43 : 1),
 (507525709 : 11433453531221 : 1)]
 Got:
     [(-11 : 29 : 1), (-2 : -28 : 1), (4 : 11 : 1), (13 : 29 : 1),
 (507525709 : -11433961056931 : 1)]
 **********************************************************************
 File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.8.alpha3/devel/sage-
 main/sage/schemes/elliptic_curves/ell_int_points.py", line 22:
     sage: E.integral_points()
 Expected:
     [(-41 : -266 : 1), (-27 : 294 : 1), (-13 : 266 : 1), (19 : 74 : 1),
 (22
     : -49 : 1), (27 : -6 : 1), (29 : -14 : 1), (43 : -154 : 1), (53 : 266
 :
     1), (71 : 490 : 1), (414 : -8379 : 1), (1639 : 66346 : 1), (1667 :
     -68054 : 1), (23036693 : 110568192854 : 1)]
 Got:
     [(-41 : 266 : 1), (-27 : 294 : 1), (-13 : -266 : 1), (19 : 74 : 1),
 (22 : -49 : 1), (27 : 6 : 1), (29 : -14 : 1), (43 : 154 : 1), (53 : 266 :
 1), (71 : -490 : 1), (414 : 8379 : 1), (1639 : 66346 : 1), (1667 : 68054 :
 1), (23036693 : 110568192854 : 1)]
 **********************************************************************
 File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.8.alpha3/devel/sage-
 main/sage/schemes/elliptic_curves/ell_int_points.py", line 31:
     sage: E.integral_points(algorithm = "old")
 Expected:
     [(-1 : 0 : 1), (0 : 6 : 1), (3 : 12 : 1), (10 : 33 : 1), (15 : 56 :
 1), (24 : 110 : 1), (43 : 264
     : 1), (98 : 924 : 1), (395 : 7656 : 1)]
 Got:
     [(-1 : 0 : 1), (0 : 6 : 1), (3 : 12 : 1), (10 : 33 : 1), (15 : 56 :
 1), (24 : 110 : 1), (43 : 264 : 1), (98 : 924 : 1), (395 : 7656 : 1),
 (1681690 : 2179974753 : 1)]
 *********************************************************************
 File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.8.alpha3/devel/sage-
 main/sage/schemes/elliptic_curves/ell_int_points.py", line 34:
     sage: E.integral_points()
 Expected:
     [(-1 : 0 : 1), (0 : -7 : 1), (3 : 12 : 1), (10 : -44 : 1), (15 : 56 :
     1), (24 : 110 : 1), (43 : 264 : 1), (98 : -1023 : 1), (395 : -8052 :
 1),
     (1681690 : 2179974753 : 1)]
 Got:
     [(-1 : 0 : 1), (0 : 6 : 1), (3 : -16 : 1), (10 : 33 : 1), (15 : -72 :
 1), (24 : 110 : 1), (43 : -308 : 1), (98 : -1023 : 1), (395 : 76
 56 : 1), (1681690 : -2181656444 : 1)]
 **********************************************************************
 File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.8.alpha3/devel/sage-
 main/sage/schemes/elliptic_curves/ell_int_points.py", line 46:
     sage: E.integral_points()
 Expected:
     [(-14 : 17 : 1), (-12 : -22 : 1), (-7 : 38 : 1), (-1 : 22 : 1), (0 :
 -18
     : 1), (13 : -22 : 1), (14 : -32 : 1), (21 : 66 : 1), (33 : -192 : 1),
     (44 : 257 : 1), (63 : 458 : 1), (98 : -1012 : 1), (175 : -2398 : 1),
     (1533 : -60792 : 1), (1561 : 60896 : 1), (18888968 : -82103620687 :
 1)]
 Got:
     [(-14 : 17 : 1), (-12 : 33 : 1), (-7 : -32 : 1), (-1 : 22 : 1), (0 :
 -18 : 1), (13 : -22 : 1), (14 : 17 : 1), (21 : -88 : 1), (33 : -1
 92 : 1), (44 : -302 : 1), (63 : 458 : 1), (98 : -1012 : 1), (175 : 2222 :
 1), (1533 : -60792 : 1), (1561 : 60896 : 1), (18888968 : -821036
 20687 : 1)]
 **********************************************************************
 File "/mnt/usb1/scratch/jdemeyer/merger/sage-4.8.alpha3/devel/sage-
 main/sage/schemes/elliptic_curves/ell_int_points.py", line 131:
     sage: ellpts.abs_log_height(list(P2))
 Expected:
     1.09861228866811
 Got:
     3.21887582486820
 **********************************************************************
 }}}

 {{{
 The following tests failed:

         sage -t  -force_lib
 devel/sage/doc/en/bordeaux_2008/elliptic_curves.rst # Time out
         sage -t  -force_lib
 devel/sage/sage/schemes/elliptic_curves/ell_int_points.py # 6 doctests
 failed
 }}}

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10973#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to